linux-kernel - [PATCH] dm: Use nonseekable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1270911530-9455-1-git-send-regression-fweisbec@gmail.com>
Date:	Sat, 10 Apr 2010 16:58:50 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Alasdair G Kergon <agk@...hat.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Arnd Bergmann <arnd@...ay.de.ibm.com>,
	Arnd Bergmann <arnd@...db.de>,
	Alasdair G Kergon <agk@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: [PATCH] dm: Use nonseekable_open

From: Arnd Bergmann <arnd@...ay.de.ibm.com>

The dm control device does not implement read/write, so it has
no use for seeking. Using no_llseek prevents falling back to
default_llseek, which requires the BKL.

Signed-off-by: Arnd Bergmann <arnd@...db.de>
Cc: Alasdair G Kergon <agk@...hat.com>
[drop useless llseek = no_llseek]
Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
---
 drivers/md/dm-ioctl.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
index d7500e1..78b28eb 100644
--- a/drivers/md/dm-ioctl.c
+++ b/drivers/md/dm-ioctl.c
@@ -1593,6 +1593,7 @@ static long dm_compat_ctl_ioctl(struct file *file, uint command, ulong u)
 #endif
 
 static const struct file_operations _ctl_fops = {
+	.open = nonseekable_open,
 	.unlocked_ioctl	 = dm_ctl_ioctl,
 	.compat_ioctl = dm_compat_ctl_ioctl,
 	.owner	 = THIS_MODULE,
-- 
1.6.2.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/