linux-kernel - Re: [PATCH 2.6.34-rc4 2/8] mxc: Update GPIO for USB support on Freescale MX51 Babbage HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100413164805.GN30801@buzzloop.caiaq.de>
Date:	Tue, 13 Apr 2010 18:48:05 +0200
From:	Daniel Mack <daniel@...aq.de>
To:	Dinh.Nguyen@...escale.com
Cc:	linux-kernel@...r.kernel.org, amit.kucheria@...onical.com,
	linux@....linux.org.uk, s.hauer@...gutronix.de,
	grant.likely@...retlab.ca, r.herring@...escale.com,
	linux-arm-kernel@...ts.infradead.org, bryan.wu@...onical.com,
	valentin.longchamp@...l.ch
Subject: Re: [PATCH 2.6.34-rc4 2/8] mxc: Update GPIO for USB support on
 Freescale MX51 Babbage HW

On Tue, Apr 13, 2010 at 11:10:25AM -0500, Dinh.Nguyen@...escale.com wrote:
> This patch is part of enabling USB for Freescale MX51 Babbage HW. This
> patch updates the iomux pins for USB, and gpio line for reset the
> USB hub on the MX51 Babbage HW.
> 
> This patch applies to 2.6.34-rc4.
> 
> Signed-off-by: Dinh Nguyen <Dinh.Nguyen@...escale.com>
> ---
>  arch/arm/plat-mxc/ehci.c                    |    4 +++
>  arch/arm/plat-mxc/include/mach/iomux-mx51.h |   33 ++++++++++++++++----------
>  2 files changed, 24 insertions(+), 13 deletions(-)
> 
> diff --git a/arch/arm/plat-mxc/ehci.c b/arch/arm/plat-mxc/ehci.c
> index cb0b638..20eaddc 100644
> --- a/arch/arm/plat-mxc/ehci.c
> +++ b/arch/arm/plat-mxc/ehci.c
> @@ -186,6 +186,10 @@ int mxc_set_usbcontrol(int port, unsigned int flags)
>  		return 0;
>  	}
>  #endif /* CONFIG_MACH_MX27 */
> +#ifdef CONFIG_ARCH_MX5
> +	/* Nothing needs to be done for MX5 here */
> +	return 0;
> +#endif

This needs a cpu_is_mx5() condition. For now that's just nit-picking,
but once another platform is added, the statement will return where it
shouldn't.

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/