linux-kernel - Re: [REGRESSION PATCH V2] vsprintf: Change struct printf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1271271054.3042.4.camel@dhcp235-240.rdu.redhat.com>
Date:	Wed, 14 Apr 2010 14:50:54 -0400
From:	Eric Paris <eparis@...hat.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, fweisbec@...il.com
Subject: Re: [REGRESSION PATCH V2] vsprintf: Change struct
 printf_spec.precision from s8 to s16

On Wed, 2010-04-14 at 09:27 -0700, Joe Perches wrote:
> Commit ef0658f3de484bf9b173639cd47544584e01efa5 changed precision
> from int to s8.
> 
> There is existing kernel code that uses a larger precision.
> 
> An example from the audit code:
> 	vsnprintf(...,..., " msg='%.1024s'", (char *)data);
> which overflows precision and truncates to nothing.
> 
> Extending precision size fixes the audit system issue.
> 
> Other changes:
> 
> Change the size of the struct printf_spec.type from u16 to u8 so
> sizeof(struct printf_spec) stays as small as possible.
> Reorder the struct members so sizeof(struct printf_spec) remains 64 bits
> without alignment holes.
> Document the struct members a bit more.
> 
> Original-patch-by: Eric Paris <eparis@...hat.com>
> Signed-off-by: Joe Perches <joe@...ches.com>

Sorry slow today

Acked-by: Eric Paris <eparis@...hat.com>
Tested-by:
Review-by:
anything else?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/