linux-kernel - Re: [PATCH] block: blk-timeout.c ensure jiffies wrap is handled correctly in blk_rq_timed_out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100414185242.GN27497@kernel.dk>
Date:	Wed, 14 Apr 2010 20:52:42 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Richard Kennedy <richard@....demon.co.uk>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Hannes Reinecke <hare@...e.de>, Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH] block: blk-timeout.c  ensure jiffies wrap is handled
	correctly in blk_rq_timed_out_timer

On Wed, Apr 14 2010, Richard Kennedy wrote:
> blk_rq_timed_out_timer() relied on blk_add_timer() never returning a
> timer value of zero, but commit 7838c15b8dd18e78a523513749e5b54bda07b0cb
> removed the code that bumped this value when it was zero.
> Therefore when jiffies is near wrap we could get unlucky & not set the
> timeout value correctly.
> 
> This patch uses a flag to indicate that the timeout value was set and so
> handles jiffies wrap correctly, and it keeps all the logic in one
> function so should be easier to maintain in the future. 

Thanks applied, it also makes it a bit clearer.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/