linux-kernel - Re: is there any chance of cleaning up the "inline" chaos?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 18 Apr 2010 13:41:25 -0700
From:	Joe Perches <joe@...ches.com>
To:	"Robert P. J. Day" <rpjday@...shcourse.ca>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: is there any chance of cleaning up the "inline" chaos?

On Sun, 2010-04-18 at 16:06 -0400, Robert P. J. Day wrote:
> i mean, how many different definitions of inline are necessary?
> 
> #if !defined(CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING) || \
>     !defined(CONFIG_OPTIMIZE_INLINING) || (__GNUC__ < 4)
> # define inline         inline          __attribute__((always_inline))
> # define __inline__     __inline__      __attribute__((always_inline))
> # define __inline       __inline        __attribute__((always_inline))
> #endif

Heave to, have at it.

$ git grep -w "inline" * | wc -l
35526
$ git grep -w "__inline__" * | wc -l
872
$ git grep -w "__inline" * | wc -l
17

It looks like __inline is almost exclusively in staging
and should be easy to fix/change

__inline__ is spread around all over the place

$ git grep -wl __inline__ * | wc -l
265

It could be converted over time or in a single sweep
like the recent slab changes.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/