linux-kernel - Re: [PATCH 32/32] Staging: comedi: fix EXPORT_SYMBOL(FOO) coding style issues in ni

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100419171501.GB13162@suse.de>
Date:	Mon, 19 Apr 2010 10:15:03 -0700
From:	Greg KH <gregkh@...e.de>
To:	Maurice Dawson <mauricedawson2699@...glemail.com>
Cc:	wfp5p@...ginia.edu, mithlesh@...syssoft.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 32/32] Staging: comedi: fix EXPORT_SYMBOL(FOO) coding
 style issues in ni_labpc.c

On Mon, Apr 19, 2010 at 05:49:08PM +0100, Maurice Dawson wrote:
> This is a re-submitted patch to the ni_labpc.c file that fixes EXPORT_SYMBOL(FOO) warnings found by the checkpatch.pl tool
> 
> Signed-off-by: Maurice Dawson <mauricedawson2699@...glemail.com>
> ---
>  drivers/staging/comedi/drivers/ni_labpc.c |   31 +++++++++++++++--------------
>  1 files changed, 16 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/ni_labpc.c b/drivers/staging/comedi/drivers/ni_labpc.c
> index becbe47..26e02d9 100644
> --- a/drivers/staging/comedi/drivers/ni_labpc.c
> +++ b/drivers/staging/comedi/drivers/ni_labpc.c
> @@ -314,7 +314,6 @@ const int labpc_1200_is_unipolar[NUM_LABPC_1200_AI_RANGES] = {
>  	1,
>  	1,
>  };
> -
>  /* map range index to gain bits */
>  const int labpc_1200_ai_gain_bits[NUM_LABPC_1200_AI_RANGES] = {
>  	0x00,

Why remove this line?  Did that change any warning?

You also do that for a lot of other lines in this file, which isn't
good.

How about only fixing the warnings, and not mushing other lines up.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/