lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Apr 2010 11:49:15 +0100 From: David Howells <dhowells@...hat.com> To: "Serge E. Hallyn" <serue@...ibm.com> Cc: dhowells@...hat.com, lkml <linux-kernel@...r.kernel.org>, Ashwin Ganti <ashwin.ganti@...il.com>, Greg KH <greg@...ah.com>, rsc@...ch.com, ericvh@...il.com, linux-security-module@...r.kernel.org, Ron Minnich <rminnich@...il.com>, jt.beard@...il.com, Andrew Morton <akpm@...ux-foundation.org>, Andrew Morgan <morgan@...nel.org>, oleg@...ibm.com, Eric Paris <eparis@...hat.com>, "Eric W. Biederman" <ebiederm@...ssion.com>, linux-api@...r.kernel.org, Randy Dunlap <rdunlap@...otime.net> Subject: Re: [PATCH 3/3] p9auth: add p9auth driver Serge E. Hallyn <serue@...ibm.com> wrote: > + if (ret == 0) > + commit_creds(new); > + else > + abort_creds(new); > + > + return ret; If you make this: if (ret == 0) return commit_creds(new); abort_creds(new); return ret; then gcc can tail-call commit_creds(), which is guaranteed to return 0. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists