linux-kernel - [PATCH 3rd_time] scsi: fix operator precedence warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 Apr 2010 11:02:14 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	James Bottomley <James.Bottomley@...e.de>,
	Ravi Anand <ravi.anand@...gic.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel@...r.kernel.org,
	David C Somayajulu <david.somayajulu@...gic.com>,
	Karen Higgins <karen.higgins@...gic.com>,
	Vikas Chaudhary <vikas.chaudhary@...gic.com>
Subject: [PATCH 3rd_time] scsi: fix operator precedence warning

From: Randy Dunlap <randy.dunlap@...cle.com>

Fix operator precedence warning (from sparse), which results in the
data value always being 0:

drivers/scsi/qla4xxx/ql4_mbx.c:470:66: warning: right shift by bigger than source value

Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
Acked-by: Ravi Anand <ravi.anand@...gic.com>
Cc: David C Somayajulu <david.somayajulu@...gic.com>
Cc: Karen Higgins <karen.higgins@...gic.com>
Cc: Vikas Chaudhary <vikas.chaudhary@...gic.com>
---

 drivers/scsi/qla4xxx/ql4_mbx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.34-rc3-git5.orig/drivers/scsi/qla4xxx/ql4_mbx.c
+++ linux-2.6.34-rc3-git5/drivers/scsi/qla4xxx/ql4_mbx.c
@@ -467,7 +467,7 @@ int qla4xxx_get_fwddb_entry(struct scsi_
 	if (conn_err_detail)
 		*conn_err_detail = mbox_sts[5];
 	if (tcp_source_port_num)
-		*tcp_source_port_num = (uint16_t) mbox_sts[6] >> 16;
+		*tcp_source_port_num = (uint16_t) (mbox_sts[6] >> 16);
 	if (connection_id)
 		*connection_id = (uint16_t) mbox_sts[6] & 0x00FF;
 	status = QLA_SUCCESS;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/