linux-kernel - Re: [PATCH 3rd_time] scsi: fix operator precedence warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <adaaasqm9ub.fsf@roland-alpha.cisco.com>
Date:	Mon, 26 Apr 2010 09:56:12 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	James Bottomley <James.Bottomley@...e.de>,
	Ravi Anand <ravi.anand@...gic.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel@...r.kernel.org,
	David C Somayajulu <david.somayajulu@...gic.com>,
	Karen Higgins <karen.higgins@...gic.com>,
	Vikas Chaudhary <vikas.chaudhary@...gic.com>
Subject: Re: [PATCH 3rd_time] scsi: fix operator precedence warning

 > -		*tcp_source_port_num = (uint16_t) mbox_sts[6] >> 16;
 > +		*tcp_source_port_num = (uint16_t) (mbox_sts[6] >> 16);

I wonder why we need that cast at all?  The fact that
tcp_source_port_num is a uint16_t* should cause the value to get
truncated properly anyway.

But I agree that this patch is a minimal fix for a real bug.
-- 
Roland Dreier <rolandd@...co.com> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/