linux-kernel - Re: [PATCH 1/1][BUG][TAKE2] KEYRINGS: find_keyring_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1790.1272037936@redhat.com>
Date:	Fri, 23 Apr 2010 16:52:16 +0100
From:	David Howells <dhowells@...hat.com>
To:	Toshiyuki Okajima <toshi.okajima@...fujitsu.com>
Cc:	dhowells@...hat.com, keyrings@...ux-nfs.org, security@...nel.org,
	linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1][BUG][TAKE2] KEYRINGS: find_keyring_by_name() can gain the freed keyring

Toshiyuki Okajima <toshi.okajima@...fujitsu.com> wrote:

> > Better still, atomic_inc_not_zero().  How about the attached patch?
> Your fix looks good to me. But, if usage count of the keyring is 0,
> I think it better to return -ENOKEY immediately. 

The problem with that is that someone else may have created a keyring with the
same name that you can't then reach until the dead keyring is deleted.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/