lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 24 Apr 2010 09:32:54 +0900 (JST) From: 岡嶋 寿行 <toshi.okajima@...fujitsu.com> To: "David Howells" <dhowells@...hat.com> Cc: "Toshiyuki Okajima" <toshi.okajima@...fujitsu.com>, dhowells@...hat.com, keyrings@...ux-nfs.org, security@...nel.org, linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/1][BUG][TAKE2] KEYRINGS: find_keyring_by_name() can gain the freed keyring > Toshiyuki Okajima <toshi.okajima@...fujitsu.com> wrote: > >> > Better still, atomic_inc_not_zero(). How about the attached patch? >> Your fix looks good to me. But, if usage count of the keyring is 0, >> I think it better to return -ENOKEY immediately. > > The problem with that is that someone else may have created a keyring with > the > same name that you can't then reach until the dead keyring is deleted. OK. I understand. --- Once find_keyring_by_name() returns -ENOKEY, the new user creates a new key. So, both the deleting key and the new key may exist. Therefore at next find_keyring_by_name() call, we should find the new key and ignore the deleting key. --- Toshiyuki Okajima -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists