linux-kernel - Re: document open(/dev/snapshot) sideeffects -- was Re: [linux-pm] syncing the disks when entering sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201004232028.56005.rjw@sisk.pl>
Date:	Fri, 23 Apr 2010 20:28:55 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Pavel Machek <pavel@....cz>
Cc:	"Leisner, Martin" <Martin.Leisner@...ox.com>,
	linux-pm@...ts.linux-foundation.org, Andrew Morton <akpm@...l.org>,
	kernel list <linux-kernel@...r.kernel.org>
Subject: Re: document open(/dev/snapshot) sideeffects -- was Re: [linux-pm] syncing the disks when entering sleep

On Monday 05 April 2010, Pavel Machek wrote:
> Hi!
> 
> > > > Please note that merely _opening_ /dev/snapshot has side effects, so that's
> > > > not just "three ioctls".
> > > 
> > > I search Doc*/power/userland-swsusp.txt, and could not find mentions
> > > of sideeffects. Perhaps that should be fixed?
> > 
> > Please feel free to make the docs more complete, then.
> 
> Yes, something like this?

Yes, looks reasonable.

I've applied it to suspend-2.6/linux-next (added a changelog).

Rafael


> Signed-off-by: Pavel Machek <pavel@....cz>
> 
> --- a/Documentation/power/userland-swsusp.txt
> +++ b/Documentation/power/userland-swsusp.txt
> @@ -24,6 +24,10 @@ assumed to be in the resume mode.  The device cannot be open for simultaneous
>  reading and writing.  It is also impossible to have the device open more than
>  once at a time.
>  
> +Even opening the device has side effects. Data structures are
> +allocated, and PM_HIBERNATION_PREPARE / PM_RESTORE_PREPARE chains are
> +called.
> +
>  The ioctl() commands recognized by the device are:
>  
>  SNAPSHOT_FREEZE - freeze user space processes (the current process is
> 
> 
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/