lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Apr 2010 14:31:49 -0400 From: Chihau Chau <chihau@...il.com> To: Randy Dunlap <randy.dunlap@...cle.com> Cc: jmorris@...ei.org, eparis@...hat.com, viro@...iv.linux.org.uk, linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] Security: inode: Fix code style issues Ok 2010/4/23 Randy Dunlap <randy.dunlap@...cle.com>: > On 04/23/10 09:10, Chihau Chau wrote: >> Hi Randy, >> >> 2010/4/23 Randy Dunlap <randy.dunlap@...cle.com>: >>> On Thu, 22 Apr 2010 20:37:15 -0400 Chihau Chau wrote: >>> >>>> From: Chihau Chau <chihau@...il.com> >>>> >>>> This fixes two code style issues: >>>> >>>> - A space required after that close brace '}' >>> >>> Why? do we say that somewhere? >>> >> >> I was used the checkpatch.pl script written by Dave Jones, Joel Schopp >> and Andy Whitcroft. > > OK, thanks for the explanation. > That would be correct for something like: > > if (foo_bar) { > do_this(); > do_that(); > } else { > pr_err("fatal error"); > panic("help"); > } > > but I don't think that it's needed for nested data structures. > > >>> >>>> >>>> - A space required after that ',' >>>> >>>> Signed-off-by: Chihau Chau <chihau@...il.com> >>>> --- >>>> security/inode.c | 4 ++-- >>>> 1 files changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/security/inode.c b/security/inode.c >>>> index c3a7938..f875f47 100644 >>>> --- a/security/inode.c >>>> +++ b/security/inode.c >>>> @@ -124,7 +124,7 @@ static inline int positive(struct dentry *dentry) >>>> >>>> static int fill_super(struct super_block *sb, void *data, int silent) >>>> { >>>> - static struct tree_descr files[] = {{""}}; >>>> + static struct tree_descr files[] = { {""} }; >>>> >>>> return simple_fill_super(sb, SECURITYFS_MAGIC, files); >>>> } >>>> @@ -208,7 +208,7 @@ struct dentry *securityfs_create_file(const char *name, mode_t mode, >>>> struct dentry *dentry = NULL; >>>> int error; >>>> >>>> - pr_debug("securityfs: creating file '%s'\n",name); >>>> + pr_debug("securityfs: creating file '%s'\n", name); >>>> >>>> error = simple_pin_fs(&fs_type, &mount, &mount_count); >>>> if (error) { >>>> -- >>>> 1.5.6.3 >>>> >>>> -- >>>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >>>> the body of a message to majordomo@...r.kernel.org >>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>>> Please read the FAQ at http://www.tux.org/lkml/ >>> >>> >>> --- >>> ~Randy >>> *** Remember to use Documentation/SubmitChecklist when testing your code *** >>> >> >> >> > > > -- > ~Randy > *** Remember to use Documentation/SubmitChecklist when testing your code *** > -- Chihau Chau -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists