| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100424154951.GA11919@kroah.com> Date: Sat, 24 Apr 2010 08:49:51 -0700 From: Greg KH <greg@...ah.com> To: Eric Lescouet <Eric.Lescouet@...tuallogix.com> Cc: Alan Stern <stern@...land.harvard.edu>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org> Subject: Re: [PATCH 1/2] USB: make hub.h, hcd.h public (drivers dependency), linux-2.6.34-rc5 On Sat, Apr 24, 2010 at 08:35:01AM -0700, Greg KH wrote: > On Sat, Apr 24, 2010 at 05:08:33PM +0200, Eric Lescouet wrote: > > The usbcore headers:hcd.h and hub.h are shared between usbcore, > > HCDs and a couple of other drivers (e.g. USBIP modules). > > So, it makes sense to move them into a more public location and > > to cleanup dependency of those modules on kernel internal headers. > > Both are moved into include/linux/usb/ > > Just move one at a time. Patches should do one thing only. So this > should be at least 2 patches. > > And I thought you were going to rename hub.h to ch11.h instead? Oops, I now see patch 2 :) Anyway, how about 3 patches here? Your last one is fine, but make the first one into 2 different ones? One that does hcd.h and then one that does hub.h. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists