linux-kernel - Re: [PATCH] USB: sisusbvga: Remove the BKL from open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201004261515.56750.arnd@arndb.de>
Date:	Mon, 26 Apr 2010 15:15:56 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Alessio Igor Bogani <abogani@...ware.it>
Cc:	Oliver Neukum <oneukum@...e.de>,
	"Greg Kroah-Hartman" <gregkh@...e.de>,
	Thomas Winischhofer <thomas@...ischhofer.net>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Pete Zaitcev <zaitcev@...hat.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Fr??d??ric Weisbecker" <fweisbec@...il.com>
Subject: Re: [PATCH] USB: sisusbvga: Remove the BKL from open

On Monday 26 April 2010, Alessio Igor Bogani wrote:
> 2010/4/26 Oliver Neukum <oneukum@...e.de>:
> > Am Sonntag, 25. April 2010 12:37:10 schrieb Alessio Igor Bogani:
> >> BKL is not needed here because necessary locking is already provided
> >> by mutex sisusb->lock.
> >
> > Have you checked the fb layer doesn't need it?
> 
> The _open and _release functions are already serialized with mutex in
> fb layer. So that mutex could be removed but in my opinion this job
> should be done in a separate patch (like I have done some time ago for
> nvidiafb driver). Now I would want suggest to remove BKL here only.

What about the BKL in the sisusb_ioctl()? It seems to follow the
same logic, so I would think that you can simply remove the BKL
from the module entirely, rather than only half of it.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/