lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 27 Apr 2010 11:59:15 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	linux-next <linux-next@...r.kernel.org>,
	Steve deRosier <steve@...ybit.com>
Subject: Re: linux-next: April 27 (wireless/libertas warnings)

On Tue, Apr 27, 2010 at 08:36:37AM -0700, Randy Dunlap wrote:
> drivers/net/wireless/libertas_tf/deb_defs.h:12:1: warning: "pr_fmt" redefined
> include/linux/kernel.h:376:1: warning: this is the location of the previous definition
> drivers/net/wireless/libertas_tf/deb_defs.h:12:1: warning: "pr_fmt" redefined
> include/linux/kernel.h:376:1: warning: this is the location of the previous definition

Yup, just had this exchange w/ Stephen...

The problem comes from including slab.h before deb_defs.h (as done
in linux-next).  The version in wireless-testing avoids the warning
by including the headers in the other order, but that is a bit ugly.

Does anyone know if it is OK to #undef pr_fmt before defining it
in deb_defs.h?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ