linux-kernel - Re: [PATCH 1/3] drivers/staging/dt3155: Integrate 3 badly styled files into 1 clean file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Apr 2010 14:18:52 +0200
From:	Dan Carpenter <error27@...il.com>
To:	Greg KH <greg@...ah.com>
Cc:	Joe Perches <joe@...ches.com>, devel@...verdev.osuosl.org,
	Scott Smedley <ss@....gov.au>, Greg KH <gregkh@...e.de>,
	Jason Baldus <jason.baldus@...il.com>,
	linux-kernel@...r.kernel.org,
	Harley Sweeten <hsweeten@...ionengravers.com>,
	Simon Horman <horms@...ge.net.au>
Subject: Re: [PATCH 1/3] drivers/staging/dt3155: Integrate 3 badly styled
	files into 1 clean file

On Tue, Apr 27, 2010 at 04:02:28PM -0700, Greg KH wrote:
> On Mon, Mar 29, 2010 at 12:34:28AM -0700, Joe Perches wrote:
> > Make variables static where appropriate
> > Rename dt3155_<foo_with_long_names> variables to dt_<foo_tla>
> > to reduce code length and make more lines fit well in 80 chars
> > Remove now unnecessary .h files
> > Change indent to use tabs
> > Remove unused functions
> > Used bool more often
> > Checkpatch clean
> 
> This is too much in one patch, sorry.  It also doesn't apply due to
> other changes in these files (that you then remove in patch 3) from
> other developers.
> 

What I like is when people send in a patch that addresses all the white
space issues at once.  So from the above list it would probably fix these:

> > to reduce code length and make more lines fit well in 80 chars
> > Change indent to use tabs
> > Checkpatch clean

I have a script to check that a patch only changes whitespace and I can
check that directly from mutt.  It's in the my smatch repo:  
git://repo.or.cz/smatch.git under smatch_scripts/whitespace_only.sh

If that passes and the source still compiles then I'm pretty sure it 
doesn't break anything.  At that point I can look through it focusing on
the whitespace instead of worrying that the patch introduces bugs.

Once the whitespace is fixed the rest of the changes can be sent in 
separately and they're much smaller and easier to audit.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/