linux-kernel - linux-next: build failure after merge of the staging-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100430155205.a4171034.sfr@canb.auug.org.au>
Date:	Fri, 30 Apr 2010 15:52:05 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Greg KH <greg@...ah.com>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Benjamin Thery <benjamin.thery@...l.net>,
	NeilBrown <neilb@...e.de>
Subject: linux-next: build failure after merge of the staging-next tree

Hi Greg,

After merging the staging-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/md/md.c: In function 'level_store':
drivers/md/md.c:3029: error: too few arguments to function 'sysfs_get_dirent'

Caused by commit 262f8e4937e7b4a587923ca3c039a184668f49ec ("sysfs:
Implement sysfs tagged directory support") from the driver-core tree
interacting with commit fecc531e3cc0de60514d326c7d82f1075ed55888 ("md:
manage redundancy group in sysfs when changing level") from the md.

I have applied this fixup patch for today and can carry it as necessary.

[This could have been avoided, of course, by creating a new API (maybe
sysfs_get_dirent_tagged) and implementing the old API in terms of that].

From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Fri, 30 Apr 2010 15:00:20 +1000
Subject: [PATCH] md: fixup for sysfs_get_dirent API change

Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 drivers/md/md.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 7f23558..b075b26 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -3026,7 +3026,7 @@ level_store(mddev_t *mddev, const char *buf, size_t len)
 			printk(KERN_WARNING
 			       "md: cannot register extra attributes for %s\n",
 			       mdname(mddev));
-		mddev->sysfs_action = sysfs_get_dirent(mddev->kobj.sd, "sync_action");
+		mddev->sysfs_action = sysfs_get_dirent(mddev->kobj.sd, NULL, "sync_action");
 	}		
 	if (mddev->pers->sync_request != NULL &&
 	    pers->sync_request == NULL) {
-- 
1.7.1

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/