linux-kernel - Re: [PATCH 7/8] padata: Flush the padata queues actively

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100429161112.f4bb67a3.akpm@linux-foundation.org>
Date:	Thu, 29 Apr 2010 16:11:12 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Steffen Klassert <steffen.klassert@...unet.com>
Cc:	Herbert Xu <herbert@...dor.hengli.com.au>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/8] padata: Flush the padata queues actively

On Thu, 29 Apr 2010 14:44:26 +0200
Steffen Klassert <steffen.klassert@...unet.com> wrote:

> +static void padata_flush_queues(struct parallel_data *pd)
> +{
> +	int cpu;
> +	struct padata_queue *queue;
> +
> +	for_each_cpu(cpu, pd->cpumask) {
> +		queue = per_cpu_ptr(pd->queue, cpu);
> +		flush_work(&queue->pwork);
> +	}
> +
> +	del_timer_sync(&pd->timer);
> +
> +	if (atomic_read(&pd->reorder_objects))
> +		padata_reorder(pd);

padata_reorder() can fail to do anything, if someone else is holding
pd->lock.  What happens then?


> +	for_each_cpu(cpu, pd->cpumask) {
> +		queue = per_cpu_ptr(pd->queue, cpu);
> +		flush_work(&queue->swork);
> +	}
> +	BUG_ON(atomic_read(&pd->refcnt) != 0);
> +}

Are we safe against cpu hot-unplug in this code?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/