linux-kernel - Re: [PATCH 24/30] viafb: Add a driver for the video capture engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 02 May 2010 03:18:53 +0200
From:	Florian Tobias Schandinat <FlorianSchandinat@....de>
To:	Jonathan Corbet <corbet@....net>
CC:	linux-kernel@...r.kernel.org, Harald Welte <laforge@...monks.org>,
	linux-fbdev@...r.kernel.org, JosephChan@....com.tw,
	ScottFang@...tech.com.cn
Subject: Re: [PATCH 24/30] viafb: Add a driver for the video capture engine

Jonathan Corbet schrieb:
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 22c1662..a969f76 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -1516,12 +1516,21 @@ config FB_VIA
>  	  This is the frame buffer device driver for Graphics chips of VIA
>  	  UniChrome (Pro) Family (CLE266,PM800/CN400,P4M800CE/P4M800Pro/
>  	  CN700/VN800,CX700/VX700,P4M890) and Chrome9 Family (K8M890,CN896
> - 	  /P4M900,VX800)
> + 	  /P4M900,VX800,VX855)
>  	  Say Y if you have a VIA UniChrome graphics board.
>  
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called viafb.
>  
> +config FB_VIA_CAMERA
> +	tristate "VIAFB camera controller support"
> +	depends on FB_VIA
> +	select VIDEOBUF_DMA_SG
> +	help
> +	   Driver support for the integrated camera controller in VIA
> +	   Chrome9 chipsets.  Currently only tested on OLPC xo-1.5 systems
> +	   with ov7670 sensors.
> +

Probably this is not the right place for this config option. Even if it 
currently depends on the framebuffer having it there is just confusing. 
Additionally you should depend/select some V4L stuff to make the 
following compile errors go away:

ERROR: "video_ioctl2" [drivers/video/via/via-camera.ko] undefined!
ERROR: "video_device_release_empty" [drivers/video/via/via-camera.ko] 
undefined!
ERROR: "video_register_device" [drivers/video/via/via-camera.ko] undefined!
ERROR: "v4l2_i2c_new_subdev_cfg" [drivers/video/via/via-camera.ko] 
undefined!
ERROR: "v4l2_device_register" [drivers/video/via/via-camera.ko] undefined!
ERROR: "videobuf_read_stream" [drivers/video/via/via-camera.ko] undefined!
ERROR: "videobuf_mmap_free" [drivers/video/via/via-camera.ko] undefined!
ERROR: "videobuf_stop" [drivers/video/via/via-camera.ko] undefined!
ERROR: "videobuf_streamoff" [drivers/video/via/via-camera.ko] undefined!
ERROR: "videobuf_poll_stream" [drivers/video/via/via-camera.ko] undefined!
ERROR: "videobuf_mmap_mapper" [drivers/video/via/via-camera.ko] undefined!
ERROR: "video_devdata" [drivers/video/via/via-camera.ko] undefined!
ERROR: "videobuf_iolock" [drivers/video/via/via-camera.ko] undefined!
ERROR: "videobuf_reqbufs" [drivers/video/via/via-camera.ko] undefined!
ERROR: "videobuf_querybuf" [drivers/video/via/via-camera.ko] undefined!
ERROR: "videobuf_qbuf" [drivers/video/via/via-camera.ko] undefined!
ERROR: "videobuf_dqbuf" [drivers/video/via/via-camera.ko] undefined!
ERROR: "videobuf_streamon" [drivers/video/via/via-camera.ko] undefined!
ERROR: "v4l2_chip_match_host" [drivers/video/via/via-camera.ko] undefined!
ERROR: "v4l2_device_unregister" [drivers/video/via/via-camera.ko] undefined!
ERROR: "video_unregister_device" [drivers/video/via/via-camera.ko] 
undefined!
ERROR: "videobuf_alloc" [drivers/media/video/videobuf-dma-sg.ko] undefined!
ERROR: "videobuf_queue_core_init" 
[drivers/media/video/videobuf-dma-sg.ko] undefined!

Otherwise you can count this patch series as
Acked-by: Florian Tobias Schandinat <FlorianSchandinat@....de>
Although it is still far away from destination and has its issues but 
it's a step forward and delaying it would be probably just frustrating 
for both of us.

Thanks,

Florian Tobias Schandinat
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/