linux-kernel - Re: [PATCH 24/30] viafb: Add a driver for the video capture engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100501195251.50093ddb@bike.lwn.net>
Date:	Sat, 1 May 2010 19:52:51 -0600
From:	Jonathan Corbet <corbet@....net>
To:	Florian Tobias Schandinat <FlorianSchandinat@....de>
Cc:	linux-kernel@...r.kernel.org, Harald Welte <laforge@...monks.org>,
	linux-fbdev@...r.kernel.org, JosephChan@....com.tw,
	ScottFang@...tech.com.cn
Subject: Re: [PATCH 24/30] viafb: Add a driver for the video capture engine

On Sun, 02 May 2010 03:18:53 +0200
Florian Tobias Schandinat <FlorianSchandinat@....de> wrote:

> > +config FB_VIA_CAMERA
> > +	tristate "VIAFB camera controller support"
> > +	depends on FB_VIA
> > +	select VIDEOBUF_DMA_SG
> > +	help
> > +	   Driver support for the integrated camera controller in VIA
> > +	   Chrome9 chipsets.  Currently only tested on OLPC xo-1.5 systems
> > +	   with ov7670 sensors.
> > +  
> 
> Probably this is not the right place for this config option. Even if it 
> currently depends on the framebuffer having it there is just confusing. 

It's the wrong place for the driver as a whole; it needs to move to
drivers/media/video, and the configuration option with it.  As noted,
the camera driver isn't ready for submission yet; that's on a list of
about a half-dozen things that need fixing.  There's just a bit more
stuff to separate to make that move possible.

One other thing to consider is moving via-core, i2c, and gpio to
drivers/mfd.  It's perhaps a more logical place for it, but I'm not
sure there's a lot of value in making that move.

> Additionally you should depend/select some V4L stuff to make the 
> following compile errors go away:

OK.  A half-dozen plus one things to fix.

> Otherwise you can count this patch series as
> Acked-by: Florian Tobias Schandinat <FlorianSchandinat@....de>
> Although it is still far away from destination and has its issues but 
> it's a step forward and delaying it would be probably just frustrating 
> for both of us.

Thanks for reviewing it!

There are definitely things to fix, and I expect some of them to last
past the merge window.  But, hopefully, it's progress, and it's very
much my intention to continue to make things better.

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/