linux-kernel - Re: [PATCH]PM QOS refresh against next-20100430

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100503103300.6330e522@bike.lwn.net>
Date:	Mon, 3 May 2010 10:33:00 -0600
From:	Jonathan Corbet <corbet@....net>
To:	mgross@...ux.intel.com
Cc:	Kevin Hilman <khilman@...prootsystems.com>, aili@...eaurora.org,
	dwalker@...eaurora.org, tiwai@...e.de, bruce.w.allan@...el.com,
	davidb@...cinc.com, mcgrof@...il.com, pavel@....cz,
	linux-pm <linux-pm@...ts.linux-foundation.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH]PM QOS refresh against next-20100430

On Fri, 30 Apr 2010 14:20:43 -0700
mark gross <mgross@...ux.intel.com> wrote:

> This patch changes the string based list management to a handle base
> implementation to help with the hot path use of pm-qos

Having taken a quick look, I think the API change makes a lot of
sense.  Hot paths are one thing; avoidance of accidental conflicts
would be another.

One question, though...  one clear use of this API is for drivers to
say "don't go into C3 or deeper because things go wrong"; I'm about to
add another one of those.  It works, but the use of a
PM_QOS_CPU_DMA_LATENCY requirement with a hard-coded number that one
hopes is small enough seems a bit...indirect.  I wonder if it would be
clearer and more robust to add a new requirement^Wrequest type saying
"the quality of service I need is shallow sleeps only"?

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/