linux-kernel - Re: [PATCH v3] firmware_class: fix memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100503170449.GA31336@kroah.com>
Date:	Mon, 3 May 2010 10:04:49 -0700
From:	Greg KH <greg@...ah.com>
To:	Tomas Winkler <tomas.winkler@...el.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>,
	Kay Sievers <kay.sievers@...y.org>,
	David Woodhouse <David.Woodhouse@...el.com>,
	Johannes Berg <johannes@...solutions.net>,
	Ming Lei <tom.leiming@...il.com>,
	Catalin Marinas <catalin.marinas@....com>
Subject: Re: [PATCH v3] firmware_class: fix memory leak - free allocated
 pages

On Sun, May 02, 2010 at 11:21:21AM +0300, Tomas Winkler wrote:
> From: David Woodhouse <David.Woodhouse@...el.com>
> 
> fix memory leak introduced by the patch 6e03a201bbe:
> firmware: speed up request_firmware()
> 
> 1. vfree won't release pages there were allocated explicitly and mapped
> using vmap. The memory has to be vunmap-ed and the pages needs
> to be freed explicitly
> 
> 2. page array is moved into the 'struct
> firmware' so that we can free it from release_firmware()
> and not only in fw_dev_release()
> 
> The fix doesn't break the firmware load speed.
> 
> Cc: Johannes Berg <johannes@...solutions.net>
> Cc: Greg Kroah-Hartman <gregkh@...e.de>
> Cc: Ming Lei <tom.leiming@...il.com>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Singed-off-by: Kay Sievers <kay.sievers@...y.org>
> Signed-off-by: David Woodhouse <David.Woodhouse@...el.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> ---
> V2: fix authorship of the patch
> V3: fix const struct firmware breakage

Thanks, this looks much better, I've applied it now.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/