linux-kernel - Re: [PATCH] staging: winbond: phy_calibration.c Coding style fixes 1/2.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100503184741.GD10778@kroah.com>
Date:	Mon, 3 May 2010 11:47:41 -0700
From:	Greg KH <greg@...ah.com>
To:	Lars Lindley <lindley@...ote.org>
Cc:	Dan Carpenter <error27@...il.com>, gregkh@...e.de,
	penberg@...helsinki.fi, pavel@....cz, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: winbond: phy_calibration.c Coding style fixes
 1/2.

On Sun, May 02, 2010 at 10:44:12AM +0200, Lars Lindley wrote:
> On 2010-04-29 01:36, Greg KH wrote:
> > On Mon, Mar 22, 2010 at 03:50:18PM +0100, Lars Lindley wrote:
> >> On 2010-03-22 15:29, Dan Carpenter wrote:
> >>> On Mon, Mar 22, 2010 at 03:17:26PM +0100, Lars Lindley wrote:
> >>>> Whitespace and indentation fixes. Removed "commented away"
> >>>> code and revision comments.
> >>>> Checked with Dan Carpenters strip_whitespace.pl and diff.
> >>>> Compiles fine and .o file is identical before and after.
> >>>>
> >>>
> >>> 	[ snip ]
> >>>
> >>>> -#ifdef _DEBUG
> >>>> +	/* e. The result are shown in "adc_dc_cal_i[8:0] and adc_dc_cal_q[8:0]" */
> >>>> +	#ifdef _DEBUG
> >>>>  	hw_get_dxx_reg(phw_data, REG_OFFSET_READ, &val);
> >>>>  	PHY_DEBUG(("[CAL]    REG_OFFSET_READ = 0x%08X\n", val));
> >>>>  
> >>>>  	PHY_DEBUG(("[CAL]    ** adc_dc_cal_i = %d (0x%04X)\n",
> >>>> -			   _s9_to_s32(val&0x000001FF), val&0x000001FF));
> >>>> +			_s9_to_s32(val & 0x000001FF), val & 0x000001FF));
> >>>>  	PHY_DEBUG(("[CAL]    ** adc_dc_cal_q = %d (0x%04X)\n",
> >>>> -			   _s9_to_s32((val&0x0003FE00)>>9), (val&0x0003FE00)>>9));
> >>>> -#endif
> >>>> +			_s9_to_s32((val & 0x0003FE00) >> 9), (val & 0x0003FE00) >> 9));
> >>>> +	#endif
> >>>>  
> >>>
> >>> #ifdef and #endif shouldn't be indented.
> >>>
> >>> I'm really happy that you're using my script.  It feels more relaxing to 
> >>> review these when I know that no bugs were introduced.
> >>>
> >>> regard,
> >>> dan carpenter
> >>>
> >>
> >> Hi Dan.
> >>
> >> It feels good to me to.
> >> When you sit with repetitive editing for a couple of hours you're
> >> bound to make a mistake or two. :)
> >>
> >> I made a new patch that applies after these two that fixes the indentation.
> >> When we have acks for all the parts I can combine them into one patch.
> > 
> > Can you merge these together now?
> > 
> > thanks,
> > 
> > greg k-h
> > 
> 
> Same here. Patch against phy-calibration.c including the other patches.

One hunk failed, and I don't have a signed-off-by: line anymore :(

Care to redo it cleanly?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/