linux-kernel - Re: [PATCH] staging: winbond: wb35tx.c Coding style fixes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100503184832.GA10862@kroah.com>
Date:	Mon, 3 May 2010 11:48:32 -0700
From:	Greg KH <greg@...ah.com>
To:	Lars Lindley <lindley@...ote.org>
Cc:	gregkh@...e.de, penberg@...helsinki.fi, pavel@....cz,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: winbond: wb35tx.c Coding style fixes.

On Sun, May 02, 2010 at 10:48:15AM +0200, Lars Lindley wrote:
> On 2010-04-29 18:06, Greg KH wrote:
> > On Sun, Mar 28, 2010 at 10:25:25AM +0200, Lars Lindley wrote:
> >> I fixed the problems reported by checkpatch.pl except some long
> >> lines and printk:s.
> >> I also removed versioning comments.
> >> Builds fine, .o identical to before and checked it with
> >> Dan Carpenters strip_whitespace.pl and diff.
> >>
> >> Signed-off-by: Lars Lindley <lindley@...ote.org>
> > 
> > This no longer applies on linux-next due to some upstream changes.  Can
> > you rediff it and resend it?
> > 
> > thanks,
> > 
> > greg k-h
> > 
> 
> Ok, does this work better?

Close, but it still fails on the first chunk:
	patching file drivers/staging/winbond/wb35tx.c
	Hunk #1 FAILED at 1.
	Hunk #2 succeeded at 26 (offset 1 line).
	Hunk #3 succeeded at 65 (offset 1 line).
	Hunk #4 succeeded at 114 (offset 1 line).
	Hunk #5 succeeded at 125 (offset 1 line).
	Hunk #6 succeeded at 134 (offset 1 line).
	Hunk #7 succeeded at 201 (offset 1 line).
	Hunk #8 succeeded at 252 (offset 1 line).
	Hunk #9 succeeded at 264 (offset 1 line).
	Hunk #10 succeeded at 288 (offset 1 line).
	1 out of 10 hunks FAILED -- saving rejects to file drivers/staging/winbond/wb35tx.c.rej

Care to redo it on top of the linux-next tree?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/