lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87r5lry0l7.fsf@devron.myhome.or.jp>
Date:	Wed, 05 May 2010 03:37:56 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Fredrick Prashanth John Berchmans <fredrickprashanth@...il.com>
Cc:	Christoph Hellwig <hch@...radead.org>, linux-kernel@...r.kernel.org
Subject: Re: nfs accesses of FAT fs folders causes deadlock on lock_super

Fredrick Prashanth John Berchmans <fredrickprashanth@...il.com> writes:

> On Tue, May 4, 2010 at 3:32 AM, Christoph Hellwig <hch@...radead.org> wrote:
>> On Mon, May 03, 2010 at 10:59:42PM -0700, Fredrick Prashanth John Berchmans wrote:
>>> The box was running kernel version 2.6.27.10.
>>> But I think the FAT code has not changed much.
>>
>> But the nfsd code has and now doesn't call lookup from the filldir
>> callback anymore.
>>
>>
>
> Ah..I just noticed the changes in the nfsd code.
>
> But in 2.6.27.10, can it be fixed by removing the lock_super in the
> vfat_lookup.?

Basically, yes.

> Because I saw some discussions long back of regressions due to
> replacing lock_kernel by lock_super in FAT code.

Yes. Current way is ultra safer side to convert BKL. Another side was
just to remove BKL. However, at least for now, we are using current way.

So, if current way had a problem, just remove it instead of trying to
fix (then, review).

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ