linux-kernel - Re: nfs accesses of FAT fs folders causes deadlock on lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mxwfy0fc.fsf@devron.myhome.or.jp>
Date:	Wed, 05 May 2010 03:41:27 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Fredrick Prashanth John Berchmans <fredrickprashanth@...il.com>
Cc:	Christoph Hellwig <hch@...radead.org>, linux-kernel@...r.kernel.org
Subject: Re: nfs accesses of FAT fs folders causes deadlock on lock_super

Fredrick Prashanth John Berchmans <fredrickprashanth@...il.com> writes:

> On Tue, May 4, 2010 at 3:32 AM, Christoph Hellwig <hch@...radead.org> wrote:
>> On Mon, May 03, 2010 at 10:59:42PM -0700, Fredrick Prashanth John Berchmans wrote:
>>> The box was running kernel version 2.6.27.10.
>>> But I think the FAT code has not changed much.
>>
>> But the nfsd code has and now doesn't call lookup from the filldir
>> callback anymore.
>>
>>
>
> I see from nfsd code, it seems the compose_entry_fh still calls
> lookup_one_len, which is now
> called from encode_entryplus_baggage instead of entry_encode.
> Am I right?

As far as I can see, nfsd is buffering the result of readdir, then do
jobs (encode_fh, etc.) with it on other context of readdir.

Aren't you missing a buffering of nfsd_buffered_readdir()?

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/