[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 5 May 2010 18:55:32 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Tejun Heo <tj@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>, efault@....de,
avi@...hat.com, paulus@...ba.org, acme@...hat.com,
linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCHSET] sched,perf: unify tracers in sched and move perf
on top of TP
* Tejun Heo <tj@...nel.org> wrote:
> Hello,
>
> On 05/05/2010 01:38 PM, Peter Zijlstra wrote:
> > As it stands I'd argue to simply drop this whole idea. The SCHED_EVENT()
> > thing doesn't look like its worth the obfuscation and I'm very much
> > opposed to making perf and sched_notifiers rely on tracepoints.
>
> Hmmm... okay. Well, this thing is born out of Ingo's suggestion that for
> more sched notifiers to be added notification mechanisms need to be
> consolidated. As long as I can get those two notifiers needed for cmwq,
> it's okay with me. Ingo, what do you think?
I'd much rather see the *_EVENT() APIs used - but enhanced to address Peter's
objections. One change would be to add a DEFINE_EVENT_ABI() variant, which
would be called via trace_abi_*() calls. That way we always know they are
'hardwired' events in the extreme.
That then would allow the software events to be consolidated.
Peter?
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists