linux-kernel - Re: linux-next: Tree for May 6 (nouveau)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <alpine.LFD.2.00.1005061636220.12696@localhost.localdomain>
Date:	Thu, 06 May 2010 16:37:46 -0400 (EDT)
From:	Len Brown <lenb@...nel.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	David Airlie <airlied@...ux.ie>, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	dri-devel@...ts.freedesktop.org
Subject: Re: linux-next: Tree for May 6 (nouveau)

> When CONFIG_ACPI_BUTTON=m:
> 
> drivers/built-in.o: In function `nouveau_connector_detect':
> nouveau_connector.c:(.text+0x1d81cf): undefined reference to `acpi_lid_open'
> 
> 
> #ifdef CONFIG_ACPI
> 		if (!nouveau_ignorelid && !acpi_lid_open())
> 			status = connector_status_unknown;
> #endif
> 
> 
> Do you want that to be
> #ifdef CONFIG_ACPI_BUTTON
> ?
> That will still only be built when CONFIG_ACPI_BUTTON=y (not =m).
> 

intel_lvds.c seems to handle this issue without #ifdefs
by including acpi/button.h

cheers,
Len Brown, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/