linux-kernel - Re: [PATCH v21 053/100] c/r (ipc): allow allocation of a desired ipc identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 07 May 2010 13:08:17 -0400
From:	Oren Laadan <orenl@...columbia.edu>
To:	Manfred Spraul <manfred@...orfullife.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	containers@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org, Serge Hallyn <serue@...ibm.com>,
	Matt Helsley <matthltc@...ibm.com>,
	Pavel Emelyanov <xemul@...nvz.org>,
	Oleg Nesterov <oleg@...hat.com>
Subject: Re: [PATCH v21 053/100] c/r (ipc): allow allocation of a desired
 ipc identifier



Manfred Spraul wrote:
> Hi Oren,
> 
> 
> On 05/01/2010 04:15 PM, Oren Laadan wrote:
>> @@ -82,7 +82,7 @@ void shm_init_ns(struct ipc_namespace *ns)
>>    * Called with shm_ids.rw_mutex (writer) and the shp structure locked.
>>    * Only shm_ids.rw_mutex remains locked on exit.
>>    */
>> -static void do_shm_rmid(struct ipc_namespace *ns, struct 
>> kern_ipc_perm *ipcp)
>> +void do_shm_rmid(struct ipc_namespace *ns, struct kern_ipc_perm *ipcp)
>>   {
>>       struct shmid_kernel *shp;
>>       shp = container_of(ipcp, struct shmid_kernel, shm_perm);
>>    
> This hunk appears to be unrelated to the main patch.
> Is it intentional or a left-over from debugging?
> 

Good catch: it belongs in patch 55: "c/r: support shared memory 
sysv-ipc". Will move it there. Thanks for the review.

Oren.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/