linux-kernel - [PATCH] staging: vt6655: Fix kernel BUG on driver wpa initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 09 May 2010 22:10:02 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Greg Kroah-Hartman <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] staging: vt6655: Fix kernel BUG on driver wpa
 initialization

In http://bugzilla.novell.com/show_bug.cgi?id=597299, the vt6655 driver
generates a kernel BUG on a NULL pointer dereference at NULL. This problem
has been traced to a failure in the wpa_set_wpadev() routine. As the vt6656
driver does not call this routine, the vt6655 code is similarly set to skip
the call.

Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
Tested-by: Richard Meek <osl2008@...glemail.com>
Cc: Stable <stable@...nel.org>
---

Greg,

The OP for the  Novelle Bugzilla report has only reported that this patch
cures the kernel oops/panic, thus I don't know if the driver works. It seems
likely that no one actually tested the driver as it could never have worked
with the original code.

Larry
---

Index: wireless-testing/drivers/staging/vt6655/device_main.c
===================================================================
--- wireless-testing.orig/drivers/staging/vt6655/device_main.c
+++ wireless-testing/drivers/staging/vt6655/device_main.c
@@ -1090,11 +1089,13 @@ device_found1(struct pci_dev *pcid, cons
     }
 //2008-07-21-01<Add>by MikeLiu
 //register wpadev
+#if 0
    if(wpa_set_wpadev(pDevice, 1)!=0) {
      printk("Fail to Register WPADEV?\n");
         unregister_netdev(pDevice->dev);
         free_netdev(dev);
    }
+#endif
     device_print_info(pDevice);
     pci_set_drvdata(pcid, pDevice);
     return 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/