linux-kernel - Re: [PATCH -tip] perf probe: Don't compile CFI related code if elfutils is old

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BE85C51.704@redhat.com>
Date:	Mon, 10 May 2010 15:19:45 -0400
From:	Masami Hiramatsu <mhiramat@...hat.com>
To:	Arnaldo Carvalho de Melo <acme@...radead.org>
CC:	Robert Richter <robert.richter@....com>,
	Ingo Molnar <mingo@...e.hu>,
	lkml <linux-kernel@...r.kernel.org>,
	systemtap <systemtap@...rces.redhat.com>,
	Roland McGrath <roland@...hat.com>,
	DLE <dle-develop@...ts.sourceforge.net>
Subject: Re: [PATCH -tip] perf probe: Don't compile CFI related code if elfutils
 is old

Arnaldo Carvalho de Melo wrote:
> Em Mon, May 10, 2010 at 02:57:34PM -0400, Masami Hiramatsu escreveu:
>> Hmm, ok, version.h is also introduced at the same time.
>>
>> # git log ./config/version.h.in
>> commit fbc7245df72ce0142f0a21fa0f4f88c97278bf60
>> Author: Roland McGrath <roland@...hat.com>
>> Date:   Tue Dec 16 17:03:03 2008 -0800
>>
>>     Install elfutils/version.h header for library compatibility checking.
>>
>> So, I think we'd better set NO_DWARF if the elfutils
>> is older than 0.138, since we can't check API compatibility
>> easily.
> 
> Well, for that you can just add some of the code you ifdefed in this
> patch into the tools/perf/Makefile test, or better, duplicate the test,
> including just the CPI stuff in the new test, and then set NO_DWARF_CFI
> and use it as the ifdef condition :-)

Hm, I'd like to add just '#ifndef _ELFUTILS_PREREQ;#error;#endif' to
NO_DWARF checking in Makefile, because it's easier to expand to another
API dependency.

Thank you,

-- 
Masami Hiramatsu
e-mail: mhiramat@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/