linux-kernel - Re: [PATCH 4/8] x86/mrst: change clock selection logic to support medfield

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1005111748040.3401@localhost.localdomain>
Date:	Tue, 11 May 2010 17:50:28 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
cc:	Jacob Pan <jacob.jun.pan@...ux.intel.com>,
	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
	Alek Du <alek.du@...el.com>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Feng Tang <feng.tang@...el.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jacob Pan <jacob.jun.pan@...el.com>
Subject: Re: [PATCH 4/8] x86/mrst: change clock selection logic to support
 medfield

On Tue, 11 May 2010, Alan Cox wrote:

> > > +	pr_debug("cpuid result %x\n", regs[CR_EAX]);
> > > +	pr_info("Moorestown CPU %s identified\n",
> > > +		(mrst_cpu_chip == MRST_CPU_CHIP_LINCROFT) ?
> > > +		"Lincroft" : "Penwell");
> > 
> >   Are we going to add one of those for each new family ? This is
> >   really redundant bloat with no value.
> > 
> > > +	return mrst_cpu_chip;
> 
> From the driver side we need this value determined and visible to the
> drivers because some things like the IPC interface need to know rather
> than getting the cpuid magic replicated around.

Ok. That makes sense. Is there more what MRST drivers need to know ?

Thanks,

	tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/