linux-kernel - Re: [PATCH] [POWEPC] crashdump: do not fail on null pointer dereferencing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 May 2010 18:02:21 +0200
From:	Vitaly Wool <vitalywool@...il.com>
To:	Maxim Uvarov <muvarov@...il.com>
Cc:	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	uvarov@....rtsoft.ru
Subject: Re: [PATCH] [POWEPC] crashdump: do not fail on null pointer 
	dereferencing

Hi,

> diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c
> index 6f4613d..341d8af 100644
> --- a/arch/powerpc/kernel/crash.c
> +++ b/arch/powerpc/kernel/crash.c
> @@ -375,6 +375,9 @@ void default_machine_crash_shutdown(struct pt_regs *regs)
>        for_each_irq(i) {
>                struct irq_desc *desc = irq_to_desc(i);
>
> +               if (!desc || !desc->chip || !desc->chip->eoi)
> +                       continue;
> +

Kinda unlikely that desc can be NULL here :)

~Vitaly
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/