linux-kernel - Re: [PATCH] [POWEPC] crashdump: do not fail on null pointer dereferencing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1273713902.25436.6.camel@concordia>
Date:	Thu, 13 May 2010 11:25:02 +1000
From:	Michael Ellerman <michael@...erman.id.au>
To:	Vitaly Wool <vitalywool@...il.com>
Cc:	Maxim Uvarov <muvarov@...il.com>, uvarov@....rtsoft.ru,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [POWEPC] crashdump: do not fail on null pointer 
 dereferencing

On Tue, 2010-05-11 at 18:02 +0200, Vitaly Wool wrote:
> Hi,
> 
> > diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c
> > index 6f4613d..341d8af 100644
> > --- a/arch/powerpc/kernel/crash.c
> > +++ b/arch/powerpc/kernel/crash.c
> > @@ -375,6 +375,9 @@ void default_machine_crash_shutdown(struct pt_regs *regs)
> >        for_each_irq(i) {
> >                struct irq_desc *desc = irq_to_desc(i);
> >
> > +               if (!desc || !desc->chip || !desc->chip->eoi)
> > +                       continue;
> > +

Actually almost certain that desc will be NULL. When CONFIG_SPARSE_IRQ=y
(the default), irq_desc's are allocated lazily.

cheers

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)