linux-kernel - Re: [PATCH] tracing: Fix function declarations if !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1273631215.27703.17.camel@gandalf.stny.rr.com>
Date:	Tue, 11 May 2010 22:26:55 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing: Fix function declarations if
 !CONFIG_STACKTRACE

On Mon, 2010-05-10 at 11:23 +0800, Li Zefan wrote:
> ftrace_trace_stack() and frace_trace_userstacke() take a
> struct ring_buffer argument, not struct trace_array. Commit
> e77405ad("tracing: pass around ring buffer instead of tracer")
> made this change.
>
> Signed-off-by: Li Zefan <lizf@...fujitsu.com>

Thanks Li,

I'll add this when I'm finished working on the TRACE_EVENT() updates.

-- Steve

> ---
>  kernel/trace/trace.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
> index d1ce0be..58f6896 100644
> --- a/kernel/trace/trace.h
> +++ b/kernel/trace/trace.h
> @@ -405,12 +405,12 @@ void ftrace_trace_userstack(struct ring_buffer *buffer, unsigned long flags,
>  void __trace_stack(struct trace_array *tr, unsigned long flags, int skip,
>  		   int pc);
>  #else
> -static inline void ftrace_trace_stack(struct trace_array *tr,
> +static inline void ftrace_trace_stack(struct ring_buffer *buffer,
>  				      unsigned long flags, int skip, int pc)
>  {
>  }
>  
> -static inline void ftrace_trace_userstack(struct trace_array *tr,
> +static inline void ftrace_trace_userstack(struct ring_buffer *buffer,
>  					  unsigned long flags, int pc)
>  {
>  }


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/