linux-kernel - Re: [PATCH 1/2] ibft: Update iBFT handling for v1.03 of the spec.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <alpine.LFD.2.00.1005120125170.5297@localhost.localdomain>
Date:	Wed, 12 May 2010 01:26:59 -0400 (EDT)
From:	Len Brown <lenb@...nel.org>
To:	Konrad Rzeszutek Wilk <konrad@...nel.org>
Cc:	linux-kernel@...r.kernel.org, gpxe-devel@...erboot.org,
	Peter Jones <pjones@...hat.com>
Subject: Re: [PATCH 1/2] ibft: Update iBFT handling for v1.03 of the spec.


>  #define IBFT_SIGN "iBFT"
...
> +#ifdef CONFIG_ACPI
> +	/*
> +	 * One spec says "IBFT", the other says "iBFT". We have to check
> +	 * for both.
> +	 */

Really?
Which one do you see in the field?
any reason to #define "iBFT" above and not use it below?

> +	if (!ibft_addr)
> +		acpi_table_parse(ACPI_SIG_IBFT, acpi_find_ibft);
> +	if (!ibft_addr)
> +		acpi_table_parse("iBFT", acpi_find_ibft);
> +#endif /* CONFIG_ACPI */

Len Brown, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/