linux-kernel - Re: [PATCH 1/2] ibft: Update iBFT handling for v1.03 of the spec.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 May 2010 13:58:57 -0400
From:	Konrad Rzeszutek Wilk <konrad@...nok.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, gpxe-devel@...erboot.org,
	Peter Jones <pjones@...hat.com>
Subject: Re: [PATCH 1/2] ibft: Update iBFT handling for v1.03 of the spec.

> > Signed-off-by: Konrad Rzeszutek Wilk <konrad@...nel.org>
> > Reviewed-by: Mike Christie <michaelc@...wisc.edu>
>
> This should have Peter's Signed-off-by:, please.
>
Done.
> > ...
> >
> > +#ifdef CONFIG_ACPI
> > +static int __init acpi_find_ibft(struct acpi_table_header *header)
> > +{
> > +	ibft_addr = (struct acpi_table_ibft *)header;
>
> container_of() would be better here.  And maybe elsewhere, too.

Actually there is no need for that. We are just casting it, not getting any 
internal member.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/