linux-kernel - Re: [LKML] Re: [PATCH v3] ad7877: keep dma rx buffers in seperate cache lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 May 2010 14:28:51 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	vapier.adi@...il.com
Cc:	fujita.tomonori@....ntt.co.jp, npiggin@...e.de, marc@...silica.com,
	dmitry.torokhov@...il.com, jw@...ix.com, cl@...ux.com,
	penberg@...helsinki.fi, mpm@...enic.com, akpm@...ux-foundation.org,
	os@...ix.com, Michael.Hennerich@...log.com,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	dg@...ix.com, osw@...ix.com, rientjes@...gle.com,
	dbrownell@...rs.sourceforge.net, grant.likely@...retlab.ca,
	chris@...kel.net, Piet.Delaney@...silica.com
Subject: Re: [LKML] Re: [PATCH v3] ad7877: keep dma rx buffers in seperate 
	cache lines

On Wed, 12 May 2010 00:35:45 -0400
Mike Frysinger <vapier.adi@...il.com> wrote:

> On Tue, May 11, 2010 at 23:23, FUJITA Tomonori wrote:
> > Seems that kmalloc is not cacheline aligned on some architectures but
> > they works. Probably, we might be just lucky because in general they
> > allocate larger buffers than 64 for DMA via kmalloc and the buffers
> > are aligned on the size?
> 
> i think the magic combo is:
>  - DMA buffer is written to (receive)
>  - some driver state is in the same cacheline as the DMA buffer
>  - that driver state is used after the flush but before the DMA finishes
>  - only on arches that need software cache coherency
> 
> so i could see this not being an obvious issue for many people

Yeah, we don't hit such condition everyday. And as I said, SCSI
usually uses kmalloc'ed buffers rather than the cache size (buffers
are aligned on roundup_pow_of_two(the allocated size)). But I think
that we want to fix this issue explicitly. I guess that it would be
better to start a new thread about this issue.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/