linux-kernel - Re: [stable] [113/197] x86, cacheinfo: Calculate L3 indices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1005130723120.28092@pobox.suse.cz>
Date:	Thu, 13 May 2010 07:26:15 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Greg KH <greg@...ah.com>,
	Borislav Petkov <borislav.petkov@....com>,
	"Ostrovsky, Boris" <Boris.Ostrovsky@....com>,
	"Herrmann3, Andreas" <Andreas.Herrmann3@....com>,
	Greg KH <gregkh@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...nel.org" <stable@...nel.org>, Jiri Benc <jbenc@...e.cz>,
	Thomas Renninger <trenn@...e.de>, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"stable-review@...nel.org" <stable-review@...nel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [stable] [113/197] x86, cacheinfo: Calculate L3 indices

On Wed, 12 May 2010, H. Peter Anvin wrote:

> >>> So if K8_NB has failed initializing for some reason, we never go near
> >>> the pci devs and the node_to_k8_nb_misc() calls since we effectively
> >>> disable the L3 functionality.
> >>>
> >>> Thus the NULL pointer checks you remove in the patch below are
> >>> superfluous, I agree, and I have already removed those in my tree along
> >>> with the other improvements/fixes I'm working on right now.
> >>
> >> So, was there ever a patch applied that fixed the bug that Jiri found in
> >> the stable kernels with this original patch that I could apply?
> >>
> > 
> > Sounds like this patch in -tip should be promoted to mainline/stable...
> > could the AMD people please confirm?
> > 
> 
> Specifically, "waiting to hit mainline" is not an option since they are
> currently queued for .35, but we need a minimal fix in .34 -- this is
> the "stable backport".  If this "stable backport" is simply a subset of
> the patch series then let me know which ones should be moved to urgent
> and sent to Linus immediately.  I obviously don't have access to a setup
> which can replicate this particular problem.

One is already there -- 0e152cd7c16832bd5cadee0c2e41d9959bc9b6f9. This 
particular one solely was enough to fix the problem I have been hitting.

Plus there is f2b20e41407fccfcf ("x86, cacheinfo: Turn off L3 cache 
index disable feature in virtualized environments") in -tip tree, which 
fixes a crash of similar nature I have been seeing on bare metal, but for 
virtualized environments.
This one might be considered for .34/stable still.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/