linux-kernel - Re: [PATCH 05/35] x86, lmb: Add lmb_find_area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 15 May 2010 08:20:04 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Yinghai Lu <yinghai.lu@...cle.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Miller <davem@...emloft.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Johannes Weiner <hannes@...xchg.org>,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH 05/35] x86, lmb: Add lmb_find_area_size()

On Fri, 2010-05-14 at 09:33 -0700, Yinghai Lu wrote:
> On 05/14/2010 01:13 AM, Benjamin Herrenschmidt wrote:
> > On Thu, 2010-05-13 at 23:28 -0700, Yinghai wrote:
> >   
> >> this just line by line translation from early_res version to lmb
> >> changes
> >>
> >> please focus on lmb core at this point.
> >>     
> > Well, the problem is that you dig into the LMB core with those functions
> > which means I -will- break your stuff if/when I change it, for example
> > to use linked lists.
> >
> >   
> then you should don't even struct lmb, and move the definition from
> lmb.h to lmb.c

Well, figure that it's been considered :-) The only reason it's in lmb.h
is so that we can write things like for_each_lmb() as inlines, but
we could just do lmb_first() and lmb_next() and move it all out of line.

Ben.

> > Besides, the code lacks comments and explanation in the changeset. So
> > please provide that, I'm sure Thomas and Peter also want to understand
> > what's going on in the x86 side of things.
> >
> >   
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arch" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/