linux-kernel - Re: [RFC, 3/7] NUMA hotplug emulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100514014535.GA4381@shaohui>
Date:	Fri, 14 May 2010 09:45:35 +0800
From:	Shaohui Zheng <shaohui.zheng@...el.com>
To:	Greg KH <gregkh@...e.de>
Cc:	akpm@...ux-foundation.org, linux-mm@...ck.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	David Rientjes <rientjes@...gle.com>,
	Alex Chiang <achiang@...com>, linux-kernel@...r.kernel.org,
	ak@...ux.intel.com, fengguang.wu@...el.com,
	haicheng.li@...ux.intel.com, shaohui.zheng@...ux.intel.com
Subject: Re: [RFC, 3/7] NUMA hotplug emulator

On Thu, May 13, 2010 at 09:55:11AM -0700, Greg KH wrote:
> On Thu, May 13, 2010 at 07:48:35PM +0800, Shaohui Zheng wrote:
> > Userland interface to hotplug-add fake offlined nodes.
> 
> Why include 2 copies of the patch in one email?
I always try to attach the patch as attachment, it is the same with the mail
content, I guess it should take convenience when you need to save the patch 
to local, it might be a bad habbit, I will be careful when I send patch next time.
thanks for the reminding.

> 
> > Add a sysfs entry "probe" under /sys/devices/system/node/:
> > 
> >  - to show all fake offlined nodes:
> >     $ cat /sys/devices/system/node/probe
> > 
> >  - to hotadd a fake offlined node, e.g. nodeid is N:
> >     $ echo N > /sys/devices/system/node/probe
> 
> As you are trying to add a new sysfs file, please create the matching
> Documentation/ABI/ file as well.

Agree, We will document it in.

> 
> Also note that sysfs files are "one value per file", which I don't think
> this file follows, right?

Agree, the cpu/probe interface should write only, and we should create another
file to indicate the hidden nodes, such as cpu/hidden. We will follow this rule
when we send the formal patch.

Thanks greg's comments so much, have a nice day.

> 
> thanks,
> 
> greg k-h

-- 
Thanks & Regards,
Shaohui

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/