lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4BECAEF6.2090009@linux.intel.com>
Date:	Fri, 14 May 2010 10:01:26 +0800
From:	Haicheng Li <haicheng.li@...ux.intel.com>
To:	Greg KH <gregkh@...e.de>
CC:	akpm@...ux-foundation.org, linux-mm@...ck.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	David Rientjes <rientjes@...gle.com>,
	Alex Chiang <achiang@...com>, linux-kernel@...r.kernel.org,
	ak@...ux.intel.com, fengguang.wu@...el.com,
	shaohui.zheng@...ux.intel.com
Subject: Re: [RFC, 3/7] NUMA hotplug emulator

Greg KH wrote:
>> Add a sysfs entry "probe" under /sys/devices/system/node/:
>>
>>  - to show all fake offlined nodes:
>>     $ cat /sys/devices/system/node/probe
>>
>>  - to hotadd a fake offlined node, e.g. nodeid is N:
>>     $ echo N > /sys/devices/system/node/probe
> 
> As you are trying to add a new sysfs file, please create the matching
> Documentation/ABI/ file as well.

Yes, we missed it. thank you.

> Also note that sysfs files are "one value per file", which I don't think
> this file follows, right?

Sorry, we didn't make the descriptions clear enough.
It should follow "one value per file". It intends to show acceptable parameters.

For example, if we have 4 fake offlined nodes, like node 2-5, then:
   $ cat /sys/devices/system/node/probe
     2-5

Then user hotadds node3 to system:
   $ echo 3 > /sys/devices/system/node/probe
   $ cat /sys/devices/system/node/probe
     2,4-5

-haicheng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ