linux-kernel - [PATCH 0/1] tracing/sched: Fix task states in sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100516221844.515632338@osadl.org>
Date:	Mon, 17 May 2010 00:18:44 +0200
From:	Carsten Emde <C.Emde@...dl.org>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <peterz@...radead.org>
Subject: [PATCH 0/1] tracing/sched: Fix task states in sched_switch event 

Hi Ingo,

> The whole enumeration there is pointless in that .c file - it tells nothing
> to the code reader.

> If it cannot be expressed in a meaningful way then introduce
> TASK_STATE_STRINGS_INIT construct that is defined next to the strings (in a
> .h file or so) - that way it's a coherent whole.
The updated patch
- has all definitions at a common place,
- adapts the related comment,
- makes the string array declaration in fs/proc/array.c a one-liner. 

	Carsten.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/