linux-kernel - Re: [PATCH] GPIO: rdc321x fix inverted gpio data out registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100516222553.GD3236@sortiz.org>
Date:	Mon, 17 May 2010 00:25:54 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Florian Fainelli <florian@...nwrt.org>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] GPIO: rdc321x fix inverted gpio data out registers

Hi Florian,

On Sun, May 16, 2010 at 12:02:18PM +0200, Florian Fainelli wrote:
> rdc_gpio_set_value_impl has the gpio data registers 1 and 2 inverted, fix this.
> 
Patch applied, thanks a lot.

Cheers,
Samuel.


> Signed-off-by: Bernhard Loos <bernhardloos@...il.com>
> Signed-off-by: Florian Fainelli <florian@...nwrt.org>
> ---
> diff --git a/drivers/gpio/rdc321x-gpio.c b/drivers/gpio/rdc321x-gpio.c
> index 22f31dc..2762698 100644
> --- a/drivers/gpio/rdc321x-gpio.c
> +++ b/drivers/gpio/rdc321x-gpio.c
> @@ -73,7 +73,7 @@ static void rdc_gpio_set_value_impl(struct gpio_chip *chip,
>  		gpch->data_reg[reg] &= ~(1 << (gpio & 0x1f));
>  
>  	pci_write_config_dword(gpch->sb_pdev,
> -			reg ? gpch->reg1_data_base : gpch->reg2_data_base,
> +			reg ? gpch->reg2_data_base : gpch->reg1_data_base,
>  			gpch->data_reg[reg]);
>  }
>  

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/