linux-kernel - Re: [PATCH] ramzswap: Remove backing swap support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 16 May 2010 13:20:44 +0900
From:	Minchan Kim <minchan.kim@...il.com>
To:	Nitin Gupta <ngupta@...are.org>
Cc:	Greg KH <greg@...ah.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Hugh Dickins <hugh.dickins@...cali.co.uk>,
	Cyp <cyp561@...il.com>, driverdev <devel@...verdev.osuosl.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ramzswap: Remove backing swap support

Hi, Nitin.

First of all, I am sorry for not review your code.
Now, I am too busy to review your code.

When you send the patch which notify free from swap slot,
I thought it's good except one.

One thing was about naming.
Now block device operations has field naming swap_xxx_notify
(I am not sure exact name). My concern was it's very specific about swap.
So I thought we would be better to more abstract name.

I thought trim like naming as Linus said.

Anyway, I will review again at next week if it isn't merged
linux-next(or linux-mm ?? which is right?). That's because I have a
interest in your good ramzswap. :)

Sorry for late response.
See you soon.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/