linux-kernel - Re: [PATCH v2] leds-lp3944: properly handle lp3944_configure fail in lp3944

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 May 2010 11:53:28 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Antonio Ospite <ospite@...denti.unina.it>,
	Richard Purdie <rpurdie@...ux.intel.com>
Subject: Re: [PATCH v2] leds-lp3944: properly handle lp3944_configure fail
	in lp3944_probe

On Mon, May 17, 2010 at 05:47:48PM +0800, Axel Lin wrote:
> In current implementation, lp3944_probe return 0 even if lp3944_configure fail.
> Therefore, led_classdev_unregister will be executed twice
> ( in error handling of lp3944_configure and lp3944_remove ).
> This patch properly handles lp3944_configure fail in lp3944_probe.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Looks good to me.

Acked-by: Wolfram Sang <w.sang@...gutronix.de>

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)