linux-kernel - Re: [PATCH v2] leds-lp3944: properly handle lp3944_configure fail in lp3944

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100517121525.c895d8d9.ospite@studenti.unina.it>
Date:	Mon, 17 May 2010 12:15:25 +0200
From:	Antonio Ospite <ospite@...denti.unina.it>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Richard Purdie <rpurdie@...ux.intel.com>
Subject: Re: [PATCH v2] leds-lp3944: properly handle lp3944_configure fail
 in lp3944_probe

On Mon, 17 May 2010 17:47:48 +0800
Axel Lin <axel.lin@...il.com> wrote:

> In current implementation, lp3944_probe return 0 even if lp3944_configure fail.
> Therefore, led_classdev_unregister will be executed twice
> ( in error handling of lp3944_configure and lp3944_remove ).
> This patch properly handles lp3944_configure fail in lp3944_probe.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Acked-by: Antonio Ospite <ospite@...denti.unina.it>

Thanks.

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

Content of type "application/pgp-signature" skipped