linux-kernel - Re: [PATCH v2] leds-lp3944: properly handle lp3944_configure fail in lp3944

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1274873491.16229.84.camel@rex>
Date:	Wed, 26 May 2010 12:31:31 +0100
From:	Richard Purdie <rpurdie@...ys.net>
To:	Antonio Ospite <ospite@...denti.unina.it>
Cc:	Axel Lin <axel.lin@...il.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Wolfram Sang <w.sang@...gutronix.de>
Subject: Re: [PATCH v2] leds-lp3944: properly handle lp3944_configure fail
 in lp3944_probe

On Mon, 2010-05-17 at 12:15 +0200, Antonio Ospite wrote:
> On Mon, 17 May 2010 17:47:48 +0800
> Axel Lin <axel.lin@...il.com> wrote:
> 
> > In current implementation, lp3944_probe return 0 even if lp3944_configure fail.
> > Therefore, led_classdev_unregister will be executed twice
> > ( in error handling of lp3944_configure and lp3944_remove ).
> > This patch properly handles lp3944_configure fail in lp3944_probe.
> > 
> > Signed-off-by: Axel Lin <axel.lin@...il.com>
> 
> Acked-by: Antonio Ospite <ospite@...denti.unina.it>
> 

Queued in the leds tree, thanks.

Richard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/