linux-kernel - Re: [PATCH 2.6.34-rc7] HID: remove redundant key mappings from Desktop Wireless 6000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1005181041240.28092@pobox.suse.cz>
Date:	Tue, 18 May 2010 10:41:39 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Don Prince <dhprince.devel@...oo.co.uk>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.34-rc7] HID: remove redundant key mappings from
 Desktop Wireless 6000

On Mon, 17 May 2010, Don Prince wrote:

> Remove 7 redundant key mappings from Desktop Wireless 6000 that are
> already handled by the default hid code.
> 
> Signed-off-by: Don Prince <dhprince-devel@...oo.co.uk>
> 
> ---
> 
> Spotted by by Robert Schedel <r.schedel@...oo.de>
> 
> 
> diff -X /opt/scripts/diff-exclude.txt -Npaur a/drivers/hid/hid-samsung.c b/drivers/hid/hid-samsung.c
> --- a/drivers/hid/hid-samsung.c	2010-05-17 11:01:26.772377750 +0100
> +++ b/drivers/hid/hid-samsung.c	2010-05-17 20:04:36.988502775 +0100
> @@ -112,13 +112,6 @@ static int samsung_kbd_mouse_input_mappi
>  
>  	switch (usage->hid & HID_USAGE) {
>  	/* report 2 */
> -	case 0x0b5: samsung_kbd_mouse_map_key_clear(KEY_NEXTSONG); break;
> -	case 0x0b6: samsung_kbd_mouse_map_key_clear(KEY_PREVIOUSSONG); break;
> -	case 0x0b7: samsung_kbd_mouse_map_key_clear(KEY_STOPCD); break;
> -	case 0x0cd: samsung_kbd_mouse_map_key_clear(KEY_PLAYPAUSE); break;
> -	case 0x0e2: samsung_kbd_mouse_map_key_clear(KEY_MUTE); break;
> -	case 0x0e9: samsung_kbd_mouse_map_key_clear(KEY_VOLUMEUP); break;
> -	case 0x0ea: samsung_kbd_mouse_map_key_clear(KEY_VOLUMEDOWN); break;

Applied, thanks for spotting it Robert.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/